Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when trying to open DevTools for a debug session that has no VM Service #3945

Closed
DanTup opened this issue Apr 28, 2022 · 1 comment · Fixed by flutter/flutter#106337
Closed

Improve error message when trying to open DevTools for a debug session that has no VM Service #3945

DanTup opened this issue Apr 28, 2022 · 1 comment · Fixed by flutter/flutter#106337
Labels
in debugger Relates to the debug adapter or process of launching a debug session in devtools Relates to integration with Dart/Flutter DevTools is enhancement
Milestone
v3.44.0

Comments

@DanTup
Copy link
Member

DanTup commented Apr 28, 2022

See flutter/devtools#4050 (comment).
@DanTup DanTup added is enhancement in debugger Relates to the debug adapter or process of launching a debug session in devtools Relates to integration with Dart/Flutter DevTools labels Apr 28, 2022
@DanTup DanTup added this to the v3.42.0 milestone Apr 28, 2022
@DanTup DanTup mentioned this issue Apr 28, 2022
Open
@DanTup
Copy link
Member Author

DanTup commented May 25, 2022

This requires a change in the SDK DAP to pass an event to the client when app.started fires.

@DanTup DanTup modified the milestones: v3.42.0, v3.44.0 May 25, 2022
DanTup added a commit to DanTup/flutter that referenced this issue Jun 21, 2022
@DanTup
Pass app.started events to the DAP client
7a3b02a 
This allows a DAP client to know when an app has finished launching even if there is no VM Service (such as noDebug runs).

Fixes Dart-Code/Dart-Code#3945 (with some client updates).
@DanTup DanTup mentioned this issue Jun 21, 2022
Merged
8 tasks
@DanTup DanTup closed this as completed in 68cf41f Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in debugger Relates to the debug adapter or process of launching a debug session in devtools Relates to integration with Dart/Flutter DevTools is enhancement
Projects
None yet
Milestone
v3.44.0
Development

Successfully merging a pull request may close this issue.

Pass app.started events to the DAP client + dart.debuggerUris for Profile mode DanTup/flutter
1 participant
@DanTup