Test peek output doesn't contain full output (eg. stack traces)

[DanTup]

Raised by @brianegan at #3704 (comment) - the error peek window doesn't contain the stack trace that's shown in the debug pane.

[DanTup]

It occurs to me that part of the peek window in the screenshot is off-screen, and the other messages might be in there. The way show messages are shown in the peek window is a little odd IMO, but we should see if we can improve this (and if not, file VS Code suggestions).

[brianegan]

Ah ok, lemme try it again with a different theme. Perhaps my theme is doing something funky?

…

On Mon, May 16, 2022 at 10:56 AM Danny Tuppeny ***@***.***> wrote: It occurs to me that part of the peek window in the screenshot is off-screen, and the other messages might be in there. The way show messages are shown in the peek window is a little odd IMO, but we should see if we can improve this (and if not, file VS Code suggestions). — Reply to this email directly, view it on GitHub <#3963 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA65DGC3WW4AT3K6YRHKXLVKIESZANCNFSM5WAX275Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[DanTup]

I don't expect themes to alter this - but you should have a second column in the peek window that you can resize. It should show each output message including the ones with the stack trace). I don't think it's a good design, but we're limited in what we can change from extensions.

[DanTup]

The displayed output has been improved slightly:

We now filter out any messages in the form "Test failed. See exception logs above.\nThe test description was" so that they won't show up here, and then we repeat the last output message from the test as the failure message. This results in some duplication (the message shown here appears twice in the tree on the right), but because of how Dart's test runner reports an error event separately to the failure of the test (and VS Code assumes the failure always a new unseen message) any way of fixing this has some other trade-offs (like buffering messages which means the test output wouldn't be real-time).

I've also filed microsoft/vscode#150702 about the link in this output not being clickable if it includes a line/col on the end (these clickable links are handled by VS Code).