Go-to-Definition on this/super params does not navigate

[guidezpl]

Is your feature request related to a problem? Please describe.
Control+clicking typically goes looking for references (e.g. a constructor parameter). But in cases where it's unused (e.g. super.key, Ctrl+click "key"), no feedback is provided.

Describe the solution you'd like
Provide some indication that no references were found

Describe alternatives you've considered
Could also, in this specific instance, fallback to another reasonable action, such as going to the super constructor param.

Kapture.2022-06-25.at.16.24.40.mp4

[DanTup]

We can't actually provide any feeback here, the interactions are controlled by VS Code. But, wouldn't it make more sense for Ctrl+Click here to jump to the definition of key in the super classes constructor?

[guidezpl]

That's also reasonable

[DanTup]

Turns out the server already did this, but an optimisation in the LSP layer was causing it not to work correctly. Working on a fix at https://dart-review.googlesource.com/c/sdk/+/251108/.

[DanTup]

Fixed by dart-lang/sdk@d887dc8. Since it's an SDK change, it'll ship as part of a Dart/Flutter SDK release rather than Dart-Code release.