Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt on breakpoints in SDK/external packages that won't be hit #4074

Closed
DanTup opened this issue Jul 27, 2022 · 0 comments
Closed

Prompt on breakpoints in SDK/external packages that won't be hit #4074

DanTup opened this issue Jul 27, 2022 · 0 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Jul 27, 2022

We have a prompt here:

hasPromptedAboutDebugSettings = true;
const message = `You have a breakpoint outside of your workspace but debug settings are set to 'my code'. Would you like to change settings? You can also change this from the status bar while debugging.`;
const debugJustMyCodeAction = "Debug just my code";
const debugEverything = "Debug my code + packages + SDK";

But it only ever fires if you're set to "My Code". It doesn't detect if you're set to "My Code + SDK" and setting breakpoints in packages (eg. Flutter), or vice-versa. It would be good to handle these.

@DanTup DanTup added is enhancement in debugger Relates to the debug adapter or process of launching a debug session labels Jul 27, 2022
@DanTup DanTup added this to the v3.46.0 milestone Jul 27, 2022
@DanTup DanTup modified the milestones: v3.46.0, v3.48.0 Aug 1, 2022
@DanTup DanTup closed this as completed in 33e0740 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session is enhancement
Projects
None yet
Development

No branches or pull requests

1 participant