Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug Console does not focus immediately when using Flutter SDK DAP #4101

Closed
DanTup opened this issue Aug 10, 2022 · 2 comments
Closed

Debug Console does not focus immediately when using Flutter SDK DAP #4101

DanTup opened this issue Aug 10, 2022 · 2 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.50.0

Comments

@DanTup
Copy link
Member

DanTup commented Aug 10, 2022

The launchRequest doesn't respond until flutter sends an app.started event, and VS code uses the response of that request to show the console. We should look at whether we need to delay responding to launch (or attach) until app.started occurs.
@DanTup DanTup added is bug in flutter Relates to running Flutter apps in debugger Relates to the debug adapter or process of launching a debug session labels Aug 10, 2022
@DanTup DanTup added this to the v3.48.0 milestone Aug 10, 2022
@DanTup
Copy link
Member Author

DanTup commented Aug 11, 2022

@helin24 got a change open at flutter/flutter#109386 that should resolve this.

@DanTup DanTup modified the milestones: v3.48.0, v3.50.0 Aug 25, 2022
@DanTup
Copy link
Member Author

DanTup commented Aug 25, 2022

Fixed by flutter/flutter#109386.

@DanTup DanTup closed this as completed Aug 25, 2022
@DanTup DanTup added the relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Milestone
v3.50.0
Development

No branches or pull requests
1 participant
@DanTup