Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Prompt" option to "Run Pub Get on Pubspec Changes" #4110

Closed
rlipscombe opened this issue Aug 19, 2022 · 1 comment
Closed

Add "Prompt" option to "Run Pub Get on Pubspec Changes" #4110

rlipscombe opened this issue Aug 19, 2022 · 1 comment
Labels
in commands Relates to commands (usually invoked from the command Palette) is enhancement
Milestone

Comments

@rlipscombe
Copy link

When I'm doing an interactive rebase (on Windows, if that makes a difference), and VS Code is open, changes to pubspec.yaml (as the commits are replayed) cause the VS Code extension to re-run pub get. This occasionally causes git to fail the rebase, because pubspec.lock has changed while it's attempting to replay the changes.

Ideally, the extension would hold off running pub get until the rebase had finished, but I have no idea how you'd do that.

As a compromise, it would be useful if the "Run Pub Get on Pubspec Changes" was changed from a boolean to a tri-state: "Always | Prompt | Never".

@DanTup
Copy link
Member

DanTup commented Aug 22, 2022

I think detecting an in-progress rebase (and then when it finishes) might be tricky (and/or unreliable), but I think having an option to always prompt is reasonable (we already have a prompt for when you open a project and we detect the files are out of sync).

@DanTup DanTup added this to the v3.48.0 milestone Aug 22, 2022
@DanTup DanTup added the in commands Relates to commands (usually invoked from the command Palette) label Aug 22, 2022
@DanTup DanTup closed this as completed in 029850e Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in commands Relates to commands (usually invoked from the command Palette) is enhancement
Projects
None yet
Development

No branches or pull requests

2 participants