"Go to Symbol in Workspace" navigates to wrong location

[DanTup]

• Commit a0bfd8c needs reverting (+ version check adding?) once this is fixed.

Failing test:

AssertionError [ERR_ASSERTION]: /home/runner/.pub-cache/git/protobuf.dart-53a1448f6da7a8035654cf502f1c62b45885bb63/protobuf/lib/protobuf.dart should end with /src/protobuf/protobuf_enum.dart)
      + expected - actual

Can be reproduced by adding the protobuf package to a project then trying to navigate to ProtobufEnum. It takes you to the lib/protobuf.dart file which is not where the class is defined.

Issue might have started with Dart 2.18.

[DanTup]

This does seem specific to Dart v2.18. It seems to occur for parts. If a definition is inside a part class, the navigation goes to the parent part of file. I think it started with dart-lang/sdk@11c201c which (I think accidentally) changed to using the parents FileState to get the file path and LineInfo instead of the parts CompilationUnit.

[DanTup]

https://dart-review.googlesource.com/c/sdk/+/256826/

[DanTup]

Fixed by dart-lang/sdk@bd867e6.