Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Container() to Placeholder() in snippets #4136

Closed
DanTup opened this issue Sep 1, 2022 · 1 comment
Closed

Change Container() to Placeholder() in snippets #4136

DanTup opened this issue Sep 1, 2022 · 1 comment
Labels
in flutter Relates to running Flutter apps is enhancement relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Sep 1, 2022

See discussion at #3975 (comment). Empty Container()s may trigger lints, and Placeholder seems like a perfect replacement (const Placeholder()).

Needs doing in both the local snippets and the server.

@DanTup DanTup added is enhancement in flutter Relates to running Flutter apps labels Sep 1, 2022
@DanTup DanTup added this to the v3.50.0 milestone Sep 1, 2022
@DanTup DanTup modified the milestones: v3.50.0, v3.52.0 Oct 3, 2022
@DanTup DanTup modified the milestones: v3.52.0, v3.54.0 Oct 31, 2022
@DanTup DanTup added the relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available label Nov 7, 2022
@DanTup
Copy link
Member Author

DanTup commented Nov 7, 2022

@DanTup DanTup closed this as completed in 02953b3 Nov 7, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 7, 2022
Using empty Container() can trigger lints and "const Placeholder()" is preferred.

See discussion in Dart-Code/Dart-Code#3975 (comment).

Fixes Dart-Code/Dart-Code#4136.

Change-Id: I453f34f157f5667427403f2c0b9058f236895d6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in flutter Relates to running Flutter apps is enhancement relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Development

No branches or pull requests

1 participant