Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DartDocs are missing from auto-import extension members #4144

Closed
DanTup opened this issue Sep 5, 2022 · 4 comments
Closed

DartDocs are missing from auto-import extension members #4144

DanTup opened this issue Sep 5, 2022 · 4 comments
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Sep 5, 2022

Related to #4143, we're not finding the element to look up the docs.

Screenshot 2022-09-05 at 17 37 33

@DanTup DanTup added the is bug label Sep 5, 2022
@DanTup DanTup added this to the v3.50.0 milestone Sep 5, 2022
@DanTup DanTup added in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server labels Sep 5, 2022
@DanTup DanTup modified the milestones: v3.50.0, v3.52.0 Oct 3, 2022
@robertherber
Copy link

Need this badly! :) What do we need to do to enable this? Docs would be great but probably this should be default behaviour?

@DanTup DanTup changed the title Docs are missing for auto-import extension members DartsDocs are missing from auto-import extension members Oct 29, 2022
@DanTup DanTup changed the title DartsDocs are missing from auto-import extension members DartDocs are missing from auto-import extension members Oct 29, 2022
@DanTup
Copy link
Member Author

DanTup commented Oct 29, 2022

@robertherber this title might have been a little ambiguous. This wasn't about documenting how to use this, the problem is that the DartDocs are missing from the auto-import extension members. Auto-imports of extension members is enabled by default, however they'll only show up in SDKs that include the fix at dart-lang/sdk@1c8bb85 (which is not the current stable releases, although it's likely in the current beta releases). I would expect the next major stable releases of Dart/Flutter include that, so they should show up automatically (although, without dartdocs in the details pane until I've fixed this issue).

@robertherber
Copy link

Aah, gotcha 👍 Being used to the smoothness of TypeScript I feel so handicapped without this. Thanks for your work on it!

@DanTup DanTup modified the milestones: v3.52.0, v3.54.0 Oct 31, 2022
@DanTup
Copy link
Member Author

DanTup commented Nov 28, 2022

This was fixed along with #3787 in dart-lang/sdk@fc9581d:

Screenshot 2022-11-28 at 12 57 00

Requires an SDK release to show up.

@DanTup DanTup closed this as completed Nov 28, 2022
@DanTup DanTup added the relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Development

No branches or pull requests

2 participants