Gutter test icons sometimes show on wrong line when helper functions call setup/teardown

[osaxma]

Describe the bug
The bug usually occurs while creating new tests, moving them around or grouping them.. See screenshot below.

Reloading VS Code seems the only option atm to realign the buttons (closing/reopening the file does not help)

To Reproduce
Unable to reproduce at the moment. I've seen it multiple time

Expected behavior
The buttons should be aligned with tests.

Screenshots

Please complete the following information:

• Operating System and version: MacOS
• VS Code version: 1.71.2
• Dart extension version: v3.48.4
• Dart/Flutter SDK version: Dart 2.18

Additional Context
When I observed the issues, I had "editor.codeLens": false" in the VS Code settings. I've enabled the code lens now and I'll follow up with an update if the issue appears.

Related Discord discussion (here)

[DanTup]

I was able to reproduce something similar by cutting the entire file to clipboard and then pasting it back. Sometimes it updates fine, and sometimes it does not. When it does not, closing the file and re-opening it seems to fix it. Changing the name of a test also seems to fix it.

[DanTup]

Maye something to do with debouncing? If I cut the entire doc and wait for the test runner to clear, then paste, things come back correctly. If I paste before it updates, then it gets into the broken state.

[DanTup]

I think this might be a VS Code issue. I've filed microsoft/vscode#161320 with some steps to repro what seems like this issue using their sample project.

I believe VS Code's test runner is doing an internal diff and skipping some work when the tests have not really changed. However, because of our debouncing, it's easy to make a set of changes where the test ends up back on the same line as it was originally (and thus doesn't get updated), but VS Code's editor had moved the gutter icons to compensate for some change in-between.

[DanTup]

A fix has been made in VS Code: microsoft/vscode#161320. I'm not certain that it's the same issue, but I think there's a good chance. VS Code usually releases in the first week of each month, so it's probably ~2weeks away. Please let me know if you see this at all again after VS Code updates and we can do some more digging.

[osaxma]

Hi @DanTup

Thanks for your effort in looking into this.

I haven't faced the issue again so far -- probably because I turned "editor.codeLens" to true (thanks again for that awesome tip).

I'll circle back if it appears again.

[DanTup]

I had a quick scan through the code again and I suspect the CodeLens setting doesn't actually impact this now. Our test discovery works even without the CodeLens (which is show we populate the test runner even when codeLens is not enabled).

I'll keep this open a little until the VS Code release goes out and if it doesn't come up again after that, close it (or let the stale bot).

Thanks!

[github-actions]

This issue has been marked stale because it is tagged awaiting-info for 20 days with no activity. Remove the stale label or comment to prevent the issue being closed in 10 days.