Skip to content

"Inspect Widget" does not navigate to code in IDE when using new DAPs #4193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanTup opened this issue Oct 3, 2022 · 1 comment · Fixed by #4337
Closed

"Inspect Widget" does not navigate to code in IDE when using new DAPs #4193

DanTup opened this issue Oct 3, 2022 · 1 comment · Fixed by #4337
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is bug
Milestone
v3.60.0

Comments

@DanTup
Copy link
Member

DanTup commented Oct 3, 2022

The new DAPs don't handle the "inspect" event that was used to navigate the editor to code when inspecting widgets.

Perhaps it's worth considering a more specific event for navigating IDEs, since some users user inspect() for wanting to dump variables to the debug console and there's some overlap here (the API also requires a number of calls to get the widget summary which complicates things).

@jacob314 what's involved in creating a new event for this? Should I implement the old way in the new DAPs for now, or is it fairly straight-forward? (I think it would likely want to be a broadcast-style event and not a service extension that the DAP registers, to allow for multiple editors to be connected to the debugger and all receive it?).
@DanTup DanTup added is bug in flutter Relates to running Flutter apps in debugger Relates to the debug adapter or process of launching a debug session labels Oct 3, 2022
@DanTup DanTup added this to the v3.52.0 milestone Oct 3, 2022
@DanTup DanTup mentioned this issue Oct 3, 2022
Closed
@blaugold blaugold mentioned this issue Oct 8, 2022
Closed
@DanTup DanTup mentioned this issue Oct 18, 2022
Closed
@DanTup DanTup modified the milestones: v3.52.0, v3.54.0 Oct 31, 2022
@DanTup DanTup modified the milestones: v3.54.0, v3.56.0 Nov 28, 2022
@DanTup DanTup modified the milestones: v3.56.0, On Deck Dec 12, 2022
@DanTup DanTup modified the milestones: On Deck, v3.58.0 Dec 21, 2022
@DanTup DanTup mentioned this issue Dec 21, 2022
Closed
2 tasks
DanTup added a commit that referenced this issue Jan 9, 2023
@DanTup
Add support for new DAP toolEvents
31594c5 
Fixes #4193.
@DanTup DanTup mentioned this issue Jan 9, 2023
Merged
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jan 13, 2023
@DanTup
[dds/dap] Forward toolEvents on to the DAP client
3949fe9 
Progress towards Dart-Code/Dart-Code#4193.

Also related:
- flutter/flutter#118098
- 4981cbf

Change-Id: I7b1394a5d5003c24b90733f1898fe368c0485937
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278515
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
@DanTup DanTup modified the milestones: v3.58.0, v3.60.0 Jan 17, 2023
DanTup added a commit that referenced this issue Jan 25, 2023
@DanTup
Add support for new DAP toolEvents
c213a09 
Fixes #4193.
@DanTup
Copy link
Member Author

DanTup commented Jan 25, 2023

@jacob314 @CoderDake @helin24 FYI, all the relevant parts for this have landed now. To have the fix you'll need:

  • a recent Flutter master (at least flutter/flutter@06909cc)
  • the pre-release Dart extension (published today, v3.59.20230125)

Please let me know if you still see issues with this with at least those versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is bug
Projects
None yet
Milestone
v3.60.0
Development

Successfully merging a pull request may close this issue.

Add support for new DAP toolEvents Dart-Code/Dart-Code
1 participant
@DanTup