Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Method show up in import statements #4202

Closed
DanTup opened this issue Oct 5, 2022 · 1 comment
Closed

Extract Method show up in import statements #4202

DanTup opened this issue Oct 5, 2022 · 1 comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.52.0

Comments

@DanTup
Copy link
Member

DanTup commented Oct 5, 2022

Similar to #4165, @jacob314 noticed this shows up for imports:

image
@DanTup DanTup added is bug in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server labels Oct 5, 2022
@DanTup DanTup added this to the v3.52.0 milestone Oct 5, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 6, 2022
@DanTup
[analysis_server] Don't allow Extract Method on directives
ad334d8 
Fixes Dart-Code/Dart-Code#4202.

Change-Id: I273d88f3dc5cfd76f01f268485c06916bbd74e78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262430
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
@DanTup
Copy link
Member Author

DanTup commented Oct 6, 2022

Fixed by dart-lang/sdk@ad334d8.

@DanTup DanTup closed this as completed Oct 6, 2022
@DanTup DanTup added the relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Milestone
v3.52.0
Development

No branches or pull requests
1 participant
@DanTup