Quick fixes are ordered badly

[DanTup]

I would expect all ignores to be further down, and the "add import" to further up. Not sure if it's VS Code's new menu or a server issue.

[DanTup]

🤔

Using a recent bleeding-edge build.

[DanTup]

2.18.0

[DanTup]

Seems to depend on the specific text.. changing var back to Uint8List triggers it:

This seems to be match the order from the server:

{
	"id": 134,
	"jsonrpc": "2.0",
	"result": [
		{
			"kind": "source.sortMembers",
			"title": "Sort Members"
		},
		{
			"kind": "source.organizeImports",
			"title": "Organize Imports"
		},
		{
			"kind": "source.fixAll",
			"title": "Fix All"
		},
		{
			"kind": "refactor.extract",
			"title": "Extract Method"
		},
		{
			"kind": "refactor.extract",
			"title": "Extract Local Variable"
		},
		{
			"diagnostics": [],
			"edit": {},
			"kind": "quickfix.create.localVariable",
			"title": "Create local variable 'Uint8List'"
		},
		{
			"diagnostics": [],
			"edit": {},
			"kind": "quickfix.remove.unusedLocalVariable",
			"title": "Remove unused local variable"
		},
		{
			"diagnostics": [],
			"edit": {},
			"kind": "quickfix.ignore.line",
			"title": "Ignore 'prefer_final_locals' for this line"
		},
		{
			"diagnostics": [],
			"edit": {},
			"kind": "quickfix.ignore.line",
			"title": "Ignore 'unused_local_variable' for this line"
		},
		{
			"diagnostics": [],
			"edit": {},
			"kind": "quickfix.ignore.file",
			"title": "Ignore 'prefer_final_locals' for this file"
		},
		{
			"diagnostics": [],
			"edit": {},
			"kind": "quickfix.ignore.file",
			"title": "Ignore 'unused_local_variable' for this file"
		},
		{
			"diagnostics": [],
			"edit": {},
			"kind": "quickfix.create.class",
			"title": "Create class 'Uint8List'"
		},
		{
			"diagnostics": [],
			"edit": {},
			"kind": "quickfix.create.mixin",
			"title": "Create mixin 'Uint8List'"
		},
		{
			"diagnostics": [],
			"edit": {},
			"kind": "quickfix.import.librarySdk",
			"title": "Import library 'dart:typed_data'"
		}
	]
}

[DanTup]

The cause of this was that we de-dupe when there are overlapping fixes on the same line. The de-duping code created a new "combined" CodeAction which was not storing its priority properly, and always being sorted last.

Fix at https://dart-review.googlesource.com/c/sdk/+/266680.

[DanTup]

Fixed by dart-lang/sdk@00ca14f.