Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use line/col information from source locations instead of mapping tokenPosTables #4209

Closed
DanTup opened this issue Oct 7, 2022 · 1 comment
Closed

Use line/col information from source locations instead of mapping tokenPosTables #4209

DanTup opened this issue Oct 7, 2022 · 1 comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session is enhancement
Milestone
v3.52.0

Comments

@DanTup
Copy link
Member

DanTup commented Oct 7, 2022

While investigating #4208 I noticed that the responses from the VM have line/col information and we don't need to look it up from tokenPosTable (as of dart-lang/sdk@2db8f37). Assuming the data is there, this may save us fetching a lot of scripts.

(We should check both old and new DAPs).
@DanTup DanTup added is enhancement in debugger Relates to the debug adapter or process of launching a debug session labels Oct 7, 2022
@DanTup DanTup added this to the v3.52.0 milestone Oct 7, 2022
@DanTup DanTup mentioned this issue Oct 7, 2022
Closed
DanTup added a commit that referenced this issue Oct 9, 2022
@DanTup
Use line/column from script location before fetching script and using…
cf21e01 
… tokenPosTable

See #4209. This may avoid #4208 until its fix rolls out too.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 10, 2022
@DanTup
[dds/dap] Optimise computing line/col for stack frames
946eec8 
See Dart-Code/Dart-Code#4209 / Dart-Code/Dart-Code#4208.

Change-Id: I62f029d50e7b0b1964868c9221ca7b0a387dc23a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263300
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
@DanTup
Copy link
Member Author

DanTup commented Oct 10, 2022

Fixed by cf21e01 in legacy DAP and dart-lang/sdk@946eec8 for new SDK DAPs.

@maks I haven't specifically tested your issue yet, but if you're on the pre-release versions of the Dart extension (see below) then this might be #4208 might be resolved for you (since we shouldn't need to fetch the scripts - the thing that was failing - in most cases anymore).

Dart/Flutter pre-release versions

@DanTup DanTup closed this as completed Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in debugger Relates to the debug adapter or process of launching a debug session is enhancement
Projects
None yet
Milestone
v3.52.0
Development

No branches or pull requests
1 participant
@DanTup