Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rendering of Uint8List (and friends) in the debugger #4213

Closed
DanTup opened this issue Oct 11, 2022 · 2 comments
Closed

Improve rendering of Uint8List (and friends) in the debugger #4213

DanTup opened this issue Oct 11, 2022 · 2 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session is enhancement relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.58.0

Comments

@DanTup
Copy link
Member

DanTup commented Oct 11, 2022 

final a = [1, 2, 3, 4, 5, 6];
final b = Uint8List.fromList(a);
final c = Uint16List.fromList(a)

List a looks like a list, but the others do not:

Screenshot 2022-10-11 at 14 36 05

In the VM Service traffic, we can see the item has a length: 6 so we might be able to present it the same as a standard List:

Screenshot 2022-10-11 at 14 39 53
@DanTup DanTup added is enhancement in debugger Relates to the debug adapter or process of launching a debug session labels Oct 11, 2022
@DanTup DanTup added this to the v3.52.0 milestone Oct 11, 2022
@DanTup DanTup mentioned this issue Oct 11, 2022
Closed
@DanTup
Copy link
Member Author

DanTup commented Oct 11, 2022

Fixed with https://dart-review.googlesource.com/c/sdk/+/263620 in the new DAPs.

Screenshot 2022-10-11 at 17 15 48

Since this change is in the SDK, it'll show up in an SDK update.

@DanTup DanTup added the relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available label Oct 11, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 17, 2022
@DanTup
[dds/dap] Improve handling of lists in variables requests
ae352fe 
Fixes Dart-Code/Dart-Code#4204.
Fixes Dart-Code/Dart-Code#4213.

Change-Id: Ibd95a149e6f620efb690c24623bb6b9d04a794b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263620
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
@DanTup
Copy link
Member Author

DanTup commented Oct 18, 2022

Fixed by dart-lang/sdk@ae352fe. This will ship in an upcoming SDK release and applies to the new debug adapters (which will roll out progressively, but can be opted-in with "dart.previewSdkDaps": true in VS Code settings).

@DanTup DanTup closed this as completed Oct 18, 2022
@DanTup DanTup modified the milestones: v3.52.0, Next SDK Release Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in debugger Relates to the debug adapter or process of launching a debug session is enhancement relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Milestone
v3.58.0
Development

No branches or pull requests
1 participant
@DanTup