Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing TODO setting does not take immediate affect for LSP #4214

Closed
DanTup opened this issue Oct 12, 2022 · 1 comment
Closed

Changing TODO setting does not take immediate affect for LSP #4214

DanTup opened this issue Oct 12, 2022 · 1 comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.52.0

Comments

@DanTup
Copy link
Member

DanTup commented Oct 12, 2022

It seems for DAS we restart the server, but not for LSP. If the setting is now being interpreted by the server, it should handle this itself (rather than in the client).
@DanTup DanTup added is bug in editor Relates to code editing or language features labels Oct 12, 2022
@DanTup DanTup added this to the v3.52.0 milestone Oct 12, 2022
@DanTup DanTup added the in lsp/analysis server Something to be fixed in the Dart analysis server label Oct 12, 2022
@DanTup
Copy link
Member Author

DanTup commented Oct 12, 2022

https://dart-review.googlesource.com/c/sdk/+/263800

@DanTup DanTup added the relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available label Oct 12, 2022
@DanTup DanTup closed this as completed Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Milestone
v3.52.0
Development

No branches or pull requests
1 participant
@DanTup