Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad syntax highlighting from textmate grammar #4216

Closed
DanTup opened this issue Oct 13, 2022 · 0 comments · Fixed by dart-lang/dart-syntax-highlight#34
Closed

Bad syntax highlighting from textmate grammar #4216

DanTup opened this issue Oct 13, 2022 · 0 comments · Fixed by dart-lang/dart-syntax-highlight#34
Labels
in editor Relates to code editing or language features is bug
Milestone
v3.56.0

Comments

@DanTup
Copy link
Member

DanTup commented Oct 13, 2022

Screenshot 2022-10-13 at 16 09 09

extends here isn't coloured right. This might also be fixed by changes in progress in #4067.
@DanTup DanTup added is bug in editor Relates to code editing or language features labels Oct 13, 2022
@DanTup DanTup added this to the v3.52.0 milestone Oct 13, 2022
@DanTup DanTup modified the milestones: v3.52.0, v3.54.0 Oct 31, 2022
@DanTup DanTup modified the milestones: v3.54.0, v3.56.0 Nov 28, 2022
DanTup added a commit to DanTup/dart-syntax-highlight that referenced this issue Dec 7, 2022
@DanTup
Fix handling of type params/args w/ extends, and get/set as function …
cd2fc6d 
…names

Fixes Dart-Code/Dart-Code#4216.
@DanTup DanTup mentioned this issue Dec 7, 2022
Merged
@DanTup DanTup closed this as completed in 37a96b0 Dec 7, 2022
devoncarew pushed a commit to dart-lang/dart-syntax-highlight that referenced this issue Dec 7, 2022
@DanTup
Fix handling of type params/args w/ extends, and get/set as function …
515bc79 
…names (#34)

* Add some additional tests with existing behaviour

* Fix handling of type params/args w/ extends, and get/set as function names

Fixes Dart-Code/Dart-Code#4216.

* Commit changelog 🤦‍♂️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in editor Relates to code editing or language features is bug
Projects
None yet
Milestone
v3.56.0
1 participant
@DanTup