Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub package name cache is not persisted #4253

Closed
DanTup opened this issue Nov 7, 2022 · 0 comments
Closed

Pub package name cache is not persisted #4253

DanTup opened this issue Nov 7, 2022 · 0 comments
Labels
in editor Relates to code editing or language features is bug is performance
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Nov 7, 2022

The caching of the Pub package name cache is not working because of this code here:

get extensionStoragePath(): string | undefined {
const uri = this.context.globalStorageUri;
const path = uri.scheme === "file" ? fsPath(uri) : undefined;
if (path)
mkDirRecursive(path);
return path;
}

The URI is now a vscode-userdata:/ URI and we only handle file.

We should isntead keep the URI and use workspace.fs to read/write this file.

@DanTup DanTup added this to the v3.54.0 milestone Nov 7, 2022
@DanTup DanTup closed this as completed in 8e2aaf8 Nov 7, 2022
@DanTup DanTup added the in editor Relates to code editing or language features label Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is bug is performance
Projects
None yet
Development

No branches or pull requests

1 participant