Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart: Capture Debugging Logs doesn't capture "flutter run" JSON traffic when using new DAPs #4266

Closed
DanTup opened this issue Nov 14, 2022 · 0 comments · Fixed by flutter/flutter#118674
Closed

Dart: Capture Debugging Logs doesn't capture "flutter run" JSON traffic when using new DAPs #4266

DanTup opened this issue Nov 14, 2022 · 0 comments · Fixed by flutter/flutter#118674
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug
Milestone
v3.60.0

Comments

@DanTup
Copy link
Member

DanTup commented Nov 14, 2022

The base debug adapter uses sendLogsToClient to re-send VM Service traffic, but this isn't used by the Flutter adapter.
@DanTup DanTup added is bug in debugger Relates to the debug adapter or process of launching a debug session labels Nov 14, 2022
@DanTup DanTup added this to the v3.54.0 milestone Nov 14, 2022
@DanTup DanTup modified the milestones: v3.54.0, v3.56.0 Nov 28, 2022
@DanTup DanTup modified the milestones: v3.56.0, v3.58.0 Dec 19, 2022
DanTup added a commit to DanTup/flutter that referenced this issue Jan 18, 2023
@DanTup
Support logging 'flutter run' communication to DAP clients
448a44f 
Fixes Dart-Code/Dart-Code#4266.
@DanTup DanTup mentioned this issue Jan 18, 2023
Merged
8 tasks
@DanTup DanTup modified the milestones: v3.58.0, v3.60.0 Jan 19, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this issue Jan 19, 2023
@DanTup
Support logging 'flutter run' communication to DAP clients (#118674)
09bd0f6 
* Support logging 'flutter run' communication to DAP clients

Fixes Dart-Code/Dart-Code#4266.

* Fix test
@DanTup DanTup closed this as completed Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug
Projects
None yet
Milestone
v3.60.0
Development

Successfully merging a pull request may close this issue.

Support logging 'flutter run' communication to DAP clients DanTup/flutter
1 participant
@DanTup