Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent setup/teardown methods showing as runnable tests #4286

Closed
DanTup opened this issue Nov 29, 2022 · 2 comments
Closed

Prevent setup/teardown methods showing as runnable tests #4286

DanTup opened this issue Nov 29, 2022 · 2 comments
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is bug is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Nov 29, 2022

Setup/teardown methods currently show as runnable tests:

image

This is a little confusing, and trying to run them will fail. VS Code lets us use TestTags to restrict profiles, so we should be able to restrict the Run/Debug profile to "runnable tests" and then only set that tag on runnable tests.

@DanTup DanTup added is bug is enhancement in testing Relates to test execution of Dart/Flutter tests for end users labels Nov 29, 2022
@DanTup DanTup added this to the v3.54.0 milestone Nov 29, 2022
@DanTup DanTup closed this as completed in 119acb3 Nov 29, 2022
@Wdestroier
Copy link

Might not be related to this change, but after some extension or VSCode update the test results and the Run | Debug buttons are not showing anymore. I suspect the behavior may be related to this change.

Before the update:
image

After the update:
image

Dart Code extension version: v3.54.1

About VSCode:
Version: 1.70.0 (user setup)
Commit: da76f93349a72022ca4670c1b84860304616aaa2
Date: 2022-08-04T04:38:16.462Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Windows_NT x64 10.0.22000

/cc @DanTup

@DanTup
Copy link
Member Author

DanTup commented Dec 5, 2022

@Wdestroier I don't think it's related to this, as those CodeLens links are separate to the test runner integration (they're been around a lot longer than the test runner).

Could you file a new issue about this, and verify whether you can repro it in a newly created project that you could share so I can have the exact same contents? Can you also include the exact version of Dart/Flutter you're using? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is bug is enhancement
Projects
None yet
Development

No branches or pull requests

2 participants