Skip to content

Running tests using cliConsole:terminal often focuses the Debug Console, hiding the Terminal output #4287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanTup opened this issue Nov 29, 2022 · 3 comments
Closed

Running tests using cliConsole:terminal often focuses the Debug Console, hiding the Terminal output #4287

DanTup opened this issue Nov 29, 2022 · 3 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.68.0

Comments

@DanTup
Copy link
Member

DanTup commented Nov 29, 2022

While testing with the analysis_server tests, I noticed that the Debug Console gets focus even when using runInTerminalRequest, so it's not obvious where the output is going.
@DanTup DanTup added is bug in debugger Relates to the debug adapter or process of launching a debug session labels Nov 29, 2022
@DanTup DanTup added this to the v3.56.0 milestone Nov 29, 2022
@DanTup
Copy link
Member Author

DanTup commented Dec 7, 2022

Seems like a VS Code issue, I can repro in TS:

microsoft/vscode#168295

@DanTup DanTup added the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Dec 7, 2022
@DanTup DanTup modified the milestones: v3.56.0, On Deck Dec 7, 2022
@DanTup DanTup modified the milestones: On Deck, v3.62.0 Feb 27, 2023
@DanTup DanTup modified the milestones: v3.62.0, v3.64.0 Mar 23, 2023
@DanTup DanTup modified the milestones: v3.64.0, v3.66.0 Apr 4, 2023
@DanTup DanTup modified the milestones: v3.66.0, v3.68.0 May 16, 2023
@DanTup
Copy link
Member Author

DanTup commented Jun 5, 2023

https://dart-review.googlesource.com/c/sdk/+/307481

@DanTup DanTup added relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available and removed blocked on vs code / lsp / dap Requires a change in VS Code to progress labels Jun 5, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jun 7, 2023
@DanTup
[dds/dap] Respond to DAP launch request before sending runInTerminalR…
565379a 
…equest

Currently when the user configures a Dart CLI program to be run in the terminal, we ask VS Code to launch it in the terminal before we respond to the launch request. This (depending on settings) can cause VS Code to show the terminal and then switch to the Debug Console (which is both confusing and frustrating for users that opt-in to do this to access stdin of the terminal process).

This change reverses the order when using `runInTerminal` so that `launch` is responded to first.

See microsoft/vscode#168295

Fixes Dart-Code/Dart-Code#4287

Change-Id: If9a221361cc3329fb86fb17ba532043266b3438c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/307481
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
@DanTup
Copy link
Member Author

DanTup commented Jun 20, 2023

Fixed by dart-lang/sdk@565379a, requires SDK release.

@DanTup DanTup closed this as completed Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Milestone
v3.68.0
Development

No branches or pull requests
1 participant
@DanTup