Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web apps are not launched for web-service device when using new SDK DAP #4292

Closed
DanTup opened this issue Nov 30, 2022 · 2 comments · Fixed by flutter/flutter#116275
Closed

Web apps are not launched for web-service device when using new SDK DAP #4292

DanTup opened this issue Nov 30, 2022 · 2 comments · Fixed by flutter/flutter#116275
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is bug
Milestone
v3.56.0

Comments

@DanTup
Copy link
Member

DanTup commented Nov 30, 2022

The app.webLaunchUrl event isn't being passed from flutter run back to the client.
@DanTup DanTup added is bug in flutter Relates to running Flutter apps in debugger Relates to the debug adapter or process of launching a debug session labels Nov 30, 2022
@DanTup DanTup added this to the v3.56.0 milestone Nov 30, 2022
@DanTup DanTup closed this as completed in 88a2e9f Nov 30, 2022
@DanTup
Copy link
Member Author

DanTup commented Nov 30, 2022

Needs Flutter work.

@DanTup DanTup reopened this Nov 30, 2022
DanTup added a commit to DanTup/flutter that referenced this issue Nov 30, 2022
@DanTup
[flutter_tools] Forward app.webLaunchUrl event from Flutter to DAP cl…
0c4cae6 
…ients

Fixes Dart-Code/Dart-Code#4292.
@DanTup DanTup mentioned this issue Nov 30, 2022
Merged
8 tasks
@DanTup
Copy link
Member Author

DanTup commented Nov 30, 2022

Flutter PR is at flutter/flutter#116275.

mit-mit pushed a commit to mit-mit/flutter that referenced this issue Dec 6, 2022
@DanTup @christopherfujino @mit-mit
[flutter_tools] Forward app.webLaunchUrl event from Flutter to DAP cl…
f2d161b 
…ients (flutter#116275)

* [flutter_tools] Forward app.webLaunchUrl event from Flutter to DAP clients

Fixes Dart-Code/Dart-Code#4292.

* Update packages/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart

Co-authored-by: Christopher Fujino <fujino@google.com>

* Another static const instead of final

Co-authored-by: Christopher Fujino <fujino@google.com>
shogohida pushed a commit to shogohida/flutter that referenced this issue Dec 7, 2022
@DanTup @christopherfujino @shogohida
[flutter_tools] Forward app.webLaunchUrl event from Flutter to DAP cl…
38b6f80 
…ients (flutter#116275)

* [flutter_tools] Forward app.webLaunchUrl event from Flutter to DAP clients

Fixes Dart-Code/Dart-Code#4292.

* Update packages/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart

Co-authored-by: Christopher Fujino <fujino@google.com>

* Another static const instead of final

Co-authored-by: Christopher Fujino <fujino@google.com>
gspencergoog pushed a commit to gspencergoog/flutter that referenced this issue Jan 19, 2023
@DanTup @christopherfujino @gspencergoog
[flutter_tools] Forward app.webLaunchUrl event from Flutter to DAP cl…
b30089f 
…ients (flutter#116275)

* [flutter_tools] Forward app.webLaunchUrl event from Flutter to DAP clients

Fixes Dart-Code/Dart-Code#4292.

* Update packages/flutter_tools/lib/src/debug_adapters/flutter_adapter.dart

Co-authored-by: Christopher Fujino <fujino@google.com>

* Another static const instead of final

Co-authored-by: Christopher Fujino <fujino@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is bug
Projects
None yet
Milestone
v3.56.0
Development

Successfully merging a pull request may close this issue.

[flutter_tools] Forward app.webLaunchUrl event from Flutter to DAP clients DanTup/flutter
1 participant
@DanTup