Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Please click the Dart Debug extension button in the spawned browser window" message doesn't appear when using SDK DAP #4293

Closed
DanTup opened this issue Nov 30, 2022 · 1 comment · Fixed by flutter/flutter#116892
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Nov 30, 2022

In the old debug adapter, we updated the progress with:

Please click the Dart Debug extension button in the spawned browser window

This doesn't happen when using the SDK DAP because it was handled inside the debug adapter. We should change how this works and detect it from the normal output inside the extension. We can't access output here, so it needs doing in the DAP.

@DanTup DanTup added is bug in flutter Relates to running Flutter apps in debugger Relates to the debug adapter or process of launching a debug session labels Nov 30, 2022
@DanTup DanTup added this to the v3.56.0 milestone Nov 30, 2022
DanTup added a commit to DanTup/flutter that referenced this issue Dec 12, 2022
eliasyishak pushed a commit to flutter/flutter that referenced this issue Dec 19, 2022
@DanTup
Copy link
Member Author

DanTup commented Dec 19, 2022

Fixed by flutter/flutter@9f9010f.

@DanTup DanTup closed this as completed Dec 19, 2022
gspencergoog pushed a commit to gspencergoog/flutter that referenced this issue Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant