Skip to content

Disable Flutter SDK DAP pending a fix for bug #4313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanTup opened this issue Dec 21, 2022 · 2 comments
Closed

Disable Flutter SDK DAP pending a fix for bug #4313

DanTup opened this issue Dec 21, 2022 · 2 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Dec 21, 2022

See dart-lang/sdk#50802. This is the top crash in the current Flutter beta.

We should bump the version number for enabling the new SDK DAP by default until this issue is fixed. We can always bring it back down, but since there can be some delay for users updating, it seems better to be on the side of caution.

@DanTup DanTup added in flutter Relates to running Flutter apps in debugger Relates to the debug adapter or process of launching a debug session labels Dec 21, 2022
@DanTup DanTup added this to the v3.56.0 milestone Dec 21, 2022
@DanTup DanTup closed this as completed in 335d214 Dec 21, 2022
DanTup added a commit to Dart-Code/Website that referenced this issue Dec 21, 2022
@fisforfaheem
Copy link

please explain

@DanTup
Copy link
Member Author

DanTup commented Dec 21, 2022

@fisforfaheem the "DAP" is the debug adapter used to connect VS Code to the Dart runtime while debugging.

There are two implementations of this - one written in TypeScript that lives inside this repository, and a newer one written in Dart that lives inside the Dart/Flutter SDKs.

We're in the process of migrating from the old TypeScript versions to the new Dart versions, but an issue was found (linked above) that needs to be fixed. Until it's fixed (and the fix is shipped), I have disabled the rollout of the new Dart DAPs, so everyone will get the older TypeScript versions (unless they have explicitly opted into the new ones with the dart.previewSdkDaps setting).

This generally won't affect users. For the most part, both DAPs behave the same. Going forwards, all new work will be in the new Dart versions though (and once this bug is fixed, we will resume the migration).

Hope this makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps
Projects
None yet
Development

No branches or pull requests

2 participants