Skip to content

Re-enable Flutter SDK DAP for new versions #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
DanTup opened this issue Dec 21, 2022 · 4 comments
Closed
2 tasks done

Re-enable Flutter SDK DAP for new versions #4314

DanTup opened this issue Dec 21, 2022 · 4 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps
Milestone
v3.62.0

Comments

@DanTup
Copy link
Member

DanTup commented Dec 21, 2022 •
edited
Loading

@DanTup DanTup added in flutter Relates to running Flutter apps in debugger Relates to the debug adapter or process of launching a debug session labels Dec 21, 2022
@DanTup DanTup added this to the v3.58.0 milestone Dec 21, 2022
@DanTup DanTup changed the title Re-enable Flutter DAP for version after fix lands Re-enable Flutter DAP for version after dds + DevTools inspector navigation fixes land Dec 21, 2022
@DanTup DanTup modified the milestones: v3.58.0, v3.60.0 Jan 17, 2023
@DanTup
Copy link
Member Author

DanTup commented Feb 27, 2023

@christopherfujino FYI, I'm re-enabling the SDK DAP experiment for Flutter >= 3.8.0-16.

This means:

  • all Flutter pre-release users on >= 3.8.0-16 (which is the version I just got today) will begin using the SDK DAPs again
  • if/when 3.8.0 (or later) goes stable, 10% of users will begin using the SDK DAPs (this number will begin increasing after the next stable release as long as there aren't significant issues reported)

Please let me know if you hear of any issues that may be related. Ideally if there are any remaining issues that would affect enabling this for stable users, pre-release users will find them in time to be fixed before the next stable branch.

@DanTup DanTup closed this as completed in 8895b0e Feb 27, 2023
@christopherfujino
Copy link

@christopherfujino FYI, I'm re-enabling the SDK DAP experiment for Flutter >= 3.8.0-16.

This means:

  • all Flutter pre-release users on >= 3.8.0-16 (which is the version I just got today) will begin using the SDK DAPs again
  • if/when 3.8.0 (or later) goes stable, 10% of users will begin using the SDK DAPs (this number will begin increasing after the next stable release as long as there aren't significant issues reported)

Please let me know if you hear of any issues that may be related. Ideally if there are any remaining issues that would affect enabling this for stable users, pre-release users will find them in time to be fixed before the next stable branch.

SGTM, thanks for the heads up!

DanTup added a commit that referenced this issue Mar 1, 2023
@DanTup
Prepare v3.60.1
00d4e03 
This hotfix reverts #4314 because of  #4413.
@DanTup
Copy link
Member Author

DanTup commented Mar 1, 2023

FYI, I'm reverting the above and bumping it back a bit more because of #4413 (the new ToolEvent stream isn't supported by DWDS meaning there are issues with web).

I'm re-opening this to re-do once that's fixed.

@DanTup DanTup reopened this Mar 1, 2023
@DanTup DanTup modified the milestones: v3.60.0, v3.62.0 Mar 1, 2023
@DanTup DanTup changed the title Re-enable Flutter DAP for version after dds + DevTools inspector navigation fixes land Re-enable Flutter SDK DAP for new versions Mar 1, 2023
@DanTup DanTup closed this as completed in fef48bc Mar 23, 2023
@DanTup
Copy link
Member Author

DanTup commented Mar 23, 2023

The DWDS fix is in Flutter master. I've re-enabled this for >= 3.9.0-14. Will push a pre-release Dart-Code shortly, so anyone on Flutter master and the pre-release Dart extension will start getting the new DAP again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps
Projects
None yet
Milestone
v3.62.0
Development

No branches or pull requests
2 participants
@DanTup @christopherfujino