Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart:developer inspect() doesn't work in SDK DAPs #4330

Closed
DanTup opened this issue Jan 4, 2023 · 3 comments
Closed

dart:developer inspect() doesn't work in SDK DAPs #4330

DanTup opened this issue Jan 4, 2023 · 3 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.60.0

Comments

@DanTup
Copy link
Member

DanTup commented Jan 4, 2023

In the old dap, if you call inspect() we would send the object to the debug console so you can inspect/expand it.
@DanTup DanTup added is bug in debugger Relates to the debug adapter or process of launching a debug session labels Jan 4, 2023
@DanTup DanTup added this to the v3.58.0 milestone Jan 4, 2023
@DanTup DanTup modified the milestones: v3.58.0, v3.60.0 Jan 17, 2023
@DanTup
Copy link
Member Author

DanTup commented Feb 20, 2023

Screenshot 2023-02-20 at 13 01 56

@DanTup
Copy link
Member Author

DanTup commented Feb 20, 2023

https://dart-review.googlesource.com/c/sdk/+/284183

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Feb 21, 2023
@DanTup
[dds/dap] Add support for showing inspect() variables in the debug co…
43e26f1 
…nsole

This adds functionality that exists in the legacy VS Code DAP but was not reproduced here.

Calling `inspect(var)` (from `dart:developer`) would print the inspected variable to the Debug Console where the user can expand and review it (similar to using the Watch window).

Fixes Dart-Code/Dart-Code#4330.

Change-Id: Ic63e6b6eb9f149dc8d80c4efdf622fb1c05bd580
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284183
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
@DanTup DanTup added the relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available label Feb 21, 2023
@DanTup
Copy link
Member Author

DanTup commented Feb 21, 2023

Fixed by dart-lang/sdk@43e26f1.

@DanTup DanTup closed this as completed Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Milestone
v3.60.0
Development

No branches or pull requests
1 participant
@DanTup