Skip to content

External packages are not correctly detected with Dart 2.19 using legacy DAPs #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanTup opened this issue Jan 25, 2023 · 0 comments
Closed

External packages are not correctly detected with Dart 2.19 using legacy DAPs #4360

DanTup opened this issue Jan 25, 2023 · 0 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug
Milestone
v3.60.0

Comments

@DanTup
Copy link
Member

DanTup commented Jan 25, 2023 •
edited
Loading

In the legacy DAPs, our detection of which local packages are "external" (eg. from pub) depends on the paths in the pubcache:

Screenshot 2023-01-25 at 11 57 11

In Dart 2.19, pub.dartlang.org changed to pub.dev which broke this check, and external package code is considered users code. This means "debug just my code" doesn't work as expected.

There are many test failures on the bots for the stable branch since 2.19 was released.
@DanTup DanTup added is bug in debugger Relates to the debug adapter or process of launching a debug session labels Jan 25, 2023
@DanTup DanTup added this to the v3.60.0 milestone Jan 25, 2023
@DanTup DanTup closed this as completed in d949ce4 Jan 25, 2023
@DanTup DanTup mentioned this issue Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug
Projects
None yet
Milestone
v3.60.0
Development

No branches or pull requests
1 participant
@DanTup