Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selecting type name does not highlight references #4376

Closed
blaugold opened this issue Feb 4, 2023 · 1 comment
Closed

Selecting type name does not highlight references #4376

blaugold opened this issue Feb 4, 2023 · 1 comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.60.0

Comments

@blaugold
Copy link
Contributor

blaugold commented Feb 4, 2023

Describe the bug

Selecting a type name does not highlight references to the type in the current file.

To Reproduce

See video.

Expected behavior

I feel like selecting a type name did at some point cause references to be highlighted like it is the case for constructors in the included video, but I'm not sure anymore :)

Screenshots

Screen.Recording.2023-02-05.at.00.07.09.mov

Please complete the following information:

  • Operating System and version: macOS 13.1 (22C65)
  • VS Code version: 1.75.0
  • Dart extension version: 3.58.0
  • Dart/Flutter SDK version: Flutter 3.7.1 Dart 2.19.1
  • Target device (if the issue relates to Flutter debugging):
@blaugold blaugold added the is bug label Feb 4, 2023
@DanTup DanTup added this to the v3.60.0 milestone Feb 6, 2023
@DanTup DanTup added in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available labels Feb 6, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Feb 6, 2023
@DanTup
[analysis_server] Include Class/Enum/Mixin declaration names in occur…
5b09a3d 
…rences

Fixes Dart-Code/Dart-Code#4376.

Change-Id: I55cb9ca7947c828137e5e01c9b0fef4f7afe7ed4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281182
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
@DanTup
Copy link
Member

DanTup commented Feb 6, 2023

Fixed by https://dart-review.googlesource.com/c/sdk/+/281182.

This change is in the Dart analysis server so will ship with a future Dart/Flutter SDK release rather than show up in the VS Code extension release.

@DanTup DanTup closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Milestone
v3.60.0
Development

No branches or pull requests
2 participants
@DanTup @blaugold