Skip to content

Windows drive letter casing is not working correctly for LSP #4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanTup opened this issue Feb 7, 2023 · 0 comments
Closed

Windows drive letter casing is not working correctly for LSP #4378

DanTup opened this issue Feb 7, 2023 · 0 comments
Labels
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Feb 7, 2023

Release notes placeholder for fix for dart-lang/sdk#51251.

We have code that is uppercasing drive letters in many places due to the analyzer currently treating all paths as case-sensitive. At some point this code has stopped working because vs.Uri.file(pathWithUppercaseDrive).toString() has started lowercasing drive letters.

Our code should handle this, to ensure all drive letters going to the LSP server are normalised to uppercase, as we intended.

@DanTup DanTup added the is bug label Feb 7, 2023
@DanTup DanTup added this to the v3.60.0 milestone Feb 7, 2023
@DanTup DanTup closed this as completed in c30c7c8 Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant