Test status indicator is duplicated

[incendial]

Describe the bug
Noticed that the test status indicator (play button or spinner) got duplicated for the whole line length of the test.

To Reproduce
No steps. This is a new test file and I noticed that it's too much of the visual noise.

Expected behavior
Only one indicator.

Screenshots

Screen.Recording.2023-02-13.at.16.48.25.mov

Please complete the following information:

• Operating System and version: macOS 12.6
• VS Code version: 1.75.1
• Dart extension version: 3.58
• Dart/Flutter SDK version: Dart SDK version: 2.19.0 (stable) (Mon Jan 23 11:29:09 2023 -0800) on "macos_x64"
• Target device (if the issue relates to Flutter debugging): -

[DanTup]

I'm not able to reproduce this. Can you reproduce in a new file? Are there any specific steps?

[incendial]

Unfortunately, no, I don't have any steps either. Feel free to close this one if without the steps it's useless. If I see this again I'll get back.

[DanTup]

If you see it again, could you also get a screenshot of what the Test Explorer tree looks like for this file?

I'll leave this open for now with the awaiting-info tag. If you see it again post back, and otherwise the bot will close it in ~30 days. Thanks!

[github-actions]

This issue has been marked stale because it is tagged awaiting-info for 20 days with no activity. Remove the stale label or comment to prevent the issue being closed in 10 days.

[incendial]

Got this problem again

[incendial]

Test explorer:

[incendial]

I was able to repro it in one go, but then it stopped appearing 😞
Investigating...

[incendial]

As you can see, I'm waiting for the icon to appear before writing the body.

repro.mov

[DanTup]

@incendial I can repro with those steps, thank you!

[DanTup]

I think at least part of this is a VS Code bug, I've filed microsoft/vscode#176951. I'm still trying to figure out if there's more to it though (and if there is, whether it's an issue here or there).

[DanTup]

I think this might be entirely a VS Code issue. I was able to adapt their sample to have the full issue (not just duplicated icons, but them not disappearing on the next update - which is what we're seeing here). I've added some notes to microsoft/vscode#176951 (comment).

Hopefully once that issue is fixed there, it'll be good here. I'll keep this issue open to track it until it's resolved though.

[incendial]

Interesting that no one else had spotted it 😅. Thank you!

I think this might be entirely a VS Code issue.

Interesting that I had never had it with TS, for example 🤔.

[DanTup]

I think it depends on some specifics:

1. The "range" of the test covers the whole line, so VS Code will "expand" it when you're pressing <enter> inside it
2. We update the existing test (don't remove/add a new one) when you make changes
3. We compute exactly the same range when we update the test as the one that VS Code expanded to (which I think is causing VS code to short-cut some work, which doesn't re-generate the icons)

So for example the sample test provider they had always truncated the test at the end of the first line, so although the issue showed up briefly when you pressed <enter>, the update "fixed" it by replacing the test range which triggers VS Code replacing the duplicated icons.

(there's a lot of assumptions there though, we'll see what they say when it's looked at :-))

[DanTup]

This was fixed in the latest VS Code.