Skip to content

"Open in Xcode" condition is incorrect #4456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanTup opened this issue Mar 24, 2023 · 0 comments
Closed

"Open in Xcode" condition is incorrect #4456

DanTup opened this issue Mar 24, 2023 · 0 comments
Labels
in commands Relates to commands (usually invoked from the command Palette) is bug
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Mar 24, 2023

"when": "explorerResourceIsFolder && resourceFilename == ios || resourceFilename == macos && dart-code:anyFlutterProjectLoaded && dart-code:dartPlatformName == mac && dart-code:isRunningLocally",

This and/or may be interpreted incorrectly, so all the conditions aren't applying to both sides (ios/macos).

Maybe there are others that should be reviewed.

@DanTup DanTup added is bug in commands Relates to commands (usually invoked from the command Palette) labels Mar 24, 2023
@DanTup DanTup added this to the v3.62.0 milestone Mar 24, 2023
@DanTup DanTup closed this as completed in 5aede87 Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in commands Relates to commands (usually invoked from the command Palette) is bug
Projects
None yet
Development

No branches or pull requests

1 participant