Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK DAP calls setLibraryDebuggable much more than necessary #4464

Closed
DanTup opened this issue Mar 27, 2023 · 2 comments
Closed

SDK DAP calls setLibraryDebuggable much more than necessary #4464

DanTup opened this issue Mar 27, 2023 · 2 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug is performance relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.62.0

Comments

@DanTup
Copy link
Member

DanTup commented Mar 27, 2023

There are two issues:

  1. We always call setLibraryDebuggable regardless of whether the current value matches what the default would be
  2. We always call setLibraryDebuggable for every library in an isolate after a Hot Reload, even though the values would stick

We should only send them if they are both a) libraries we haven't already sent values for and b) differ from what the default would be.

We need to ensure these changes don't interfere with when the user changes the settings (applyDebugOptions) which should always re-send all, or we should track the values on the VM side and then only send if they've changed.
@DanTup DanTup added is bug in debugger Relates to the debug adapter or process of launching a debug session is performance labels Mar 27, 2023
@DanTup DanTup added this to the v3.62.0 milestone Mar 27, 2023
@DanTup
Copy link
Member Author

DanTup commented Mar 28, 2023

Possible fix in https://dart-review.googlesource.com/c/sdk/+/291282.

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Mar 29, 2023
@DanTup
[dds/dap] Don't call setLibraryDebuggable unnecessarily
1112942 
Fixes Dart-Code/Dart-Code#4464.

TEST=DAP tests included, VM changes are only a comment
Change-Id: I5ee44fda5b954d371bd00345815c24515eb14f61
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/291282
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
@DanTup
Copy link
Member Author

DanTup commented Mar 30, 2023

Fixed by dart-lang/sdk@1112942. Needs a DDS release and to roll into Flutter.

@DanTup DanTup closed this as completed Mar 30, 2023
@DanTup DanTup added the relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug is performance relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Milestone
v3.62.0
Development

No branches or pull requests
1 participant
@DanTup