Skip to content

Breakpoints unresolve when adding new breakpoints #4469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanTup opened this issue Mar 28, 2023 · 3 comments
Closed

Breakpoints unresolve when adding new breakpoints #4469

DanTup opened this issue Mar 28, 2023 · 3 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.62.0

Comments

@DanTup
Copy link
Member

DanTup commented Mar 28, 2023

Something odd going on here:

Mar-28-2023 17-22-34
@DanTup DanTup added is bug in debugger Relates to the debug adapter or process of launching a debug session labels Mar 28, 2023
@DanTup DanTup added this to the v3.62.0 milestone Mar 28, 2023
@DanTup
Copy link
Member Author

DanTup commented Mar 29, 2023

Fix at https://dart-review.googlesource.com/c/sdk/+/291763.

This may impact Dart-Code integration tests (like it impacted DDS tests) because we can't assume when setBrekapoints() returns that the VM has been updated yet.

@DanTup
Copy link
Member Author

DanTup commented Mar 29, 2023

I changed this so we still respond to setBreakpoints after the VM was notified now, but we just delay sending the events back.

@DanTup
Copy link
Member Author

DanTup commented Mar 30, 2023

Fixed by dart-lang/sdk@b984c30. Will need a DDS release and rolling into Flutter.

@DanTup DanTup closed this as completed Mar 30, 2023
@DanTup DanTup added the relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available label Mar 30, 2023
@DanTup DanTup mentioned this issue Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Milestone
v3.62.0
Development

No branches or pull requests
1 participant
@DanTup