Skip to content

"class" snippet shows up inside enum definitions #4473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanTup opened this issue Mar 30, 2023 · 1 comment
Closed

"class" snippet shows up inside enum definitions #4473

DanTup opened this issue Mar 30, 2023 · 1 comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.66.0

Comments

@DanTup
Copy link
Member

DanTup commented Mar 30, 2023

Screenshot 2023-03-30 at 14 41 30
@DanTup DanTup added is bug in editor Relates to code editing or language features labels Mar 30, 2023
@DanTup DanTup added this to the v3.64.0 milestone Mar 30, 2023
@DanTup DanTup added relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available in lsp/analysis server Something to be fixed in the Dart analysis server labels Apr 4, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Apr 4, 2023
@DanTup
[analysis_server] Fix completion snippet context for inside enum decl…
b7fbf1e 
…arations

Previously we'd fail to match anything here and end up using "top level", showing snippets for creating classes. This adds enums to "inClass" showing things like "function" snippets.

I didn't split class/enums because right now we don't have any snippets that would differ, though we might want to do this if that changes.

Fixes Dart-Code/Dart-Code#4473.

Change-Id: I67c8e2a67698fb15136cba68b63549acf29ee596
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292884
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
@DanTup
Copy link
Member Author

DanTup commented Apr 4, 2023

Fixed in dart-lang/sdk@b7fbf1e.

@DanTup DanTup closed this as completed Apr 4, 2023
@DanTup DanTup modified the milestones: v3.64.0, v3.66.0 May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Milestone
v3.66.0
Development

No branches or pull requests
1 participant
@DanTup