Skip to content

Skipped tests look like passing tests in Debug Console #4505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanTup opened this issue Apr 24, 2023 · 3 comments
Closed

Skipped tests look like passing tests in Debug Console #4505

DanTup opened this issue Apr 24, 2023 · 3 comments
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.68.0

Comments

@DanTup
Copy link
Member

DanTup commented Apr 24, 2023

Screenshot 2023-04-24 at 11 56 19
@DanTup DanTup added is bug in testing Relates to test execution of Dart/Flutter tests for end users labels Apr 24, 2023
@DanTup DanTup modified the milestones: v3.64.0, v3.66.0 Apr 24, 2023
@DanTup
Copy link
Member Author

DanTup commented Apr 24, 2023

This will need work in the debug adapters.

@DanTup DanTup modified the milestones: v3.66.0, v3.68.0 May 31, 2023
@DanTup DanTup added the relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available label May 31, 2023
@DanTup
Copy link
Member Author

DanTup commented Jun 5, 2023

https://dart-review.googlesource.com/c/sdk/+/306701

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jun 6, 2023
@DanTup
[dds/dap] Don't show skipped tests as passes in debug adapter output
30b9ac9 
Fixes Dart-Code/Dart-Code#4505

Change-Id: Ic57e5f05b62cc09194c3444437b5303f4ca54830
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306701
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
@DanTup
Copy link
Member Author

DanTup commented Jun 28, 2023

Fixed in dart-lang/sdk@30b9ac9, requires SDK update.

@DanTup DanTup closed this as completed Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Milestone
v3.68.0
Development

No branches or pull requests
1 participant
@DanTup