Imports not being added automatically from code completion in part files

[DanTup]

There's a test failing and I can repro this locally. Accepting ProcessResult here should auto-import dart:io into the part_wrapper file:

The import is never added. The resolved completion includes a "command": "edit.sendWorkspaceEdit":

{
	"id": : 20,
	"jsonrpc": : "2.0",
	"result": : {
		"additionalTextEdits": : [],
		"command": : {
			"arguments": : [
				{
					"edit": : {
						"documentChanges": : [
							{
								"edits": : [
									{
										"newText": : "import 'dart::io';\n\n",
										"range": : {
											"end": : {
												"character": : 0,
												"line": : 0
											},
											"start": : {
												"character": : 0,
												"line": : 0
											}
										}
									}
								],
								"textDocument": : {
									"uri": : "file::///C::/Dev/Test%20Projects/test_failure_import_part/lib/part_wrapper.dart",
									"version": : 1
								}
							}
						]
					}
				}
			],
			"command": : "edit.sendWorkspaceEdit",
			"title": : "Add import"
		},
		"data": : {
			"file": : "C::\\Dev\\Test Projects\\test_failure_import_part\\lib\\part.dart",
			"importUris": : [
				"dart::io"
			],
			"ref": : "dart::io;dart::io/process.dart;ProcessResult;"
		},
		"detail": : "Auto import from 'dart::io'\n\n(int pid, int exitCode, dynamic stdout, dynamic stderr) → ProcessResult",
		"filterText": : "ProcessResult",
		"insertTextFormat": : 2,
		"insertTextMode": : 1,
		"kind": : 4,
		"label": : "ProcessResult(…)",
		"sortText": : "9999509",
		"textEdit": : {
			"newText": : "ProcessResult(${1::pid}, ${2::exitCode}, ${3::stdout}, ${4::stderr})",
			"range": : {
				"end": : {
					"character": : 24,
					"line": : 3
				},
				"start": : {
					"character": : 12,
					"line": : 3
				}
			}
		}
	}
}

However, that command appears to never be called.

[DanTup]

I think this may be a VS Code issue - I've filed microsoft/vscode#184924.

[DanTup]

Looks like the LSP spec says we should also use a client capability to know which fields can be resolved later:

completionItem#resolveSupport client capability which lists all properties that can be filled in during a ‘completionItem/resolve’ request

[DanTup]

7657758 will need reverting once this is fixed to unskip the test.

[DanTup]

The change in VS Code is being reverted. We can re-enable this test once that ships.

We may still need to look at another way, but I'd like to see whether anything comes of microsoft/vscode#185772 before doing that, because that would be a nicer way to handle this.