Hovering over a for loop variable does not show its type

[incendial]

Describe the bug

Screen.Recording.2023-07-04.at.09.53.36.mov

Please complete the following information:

• Operating System and version: macOS
• VS Code version: 1.79.2
• Dart extension version: 3.66.0
• Dart/Flutter SDK version: Dart SDK version: 3.1.0-163.1.beta (beta)

[incendial]

Feels like it's related to #4626

[DanTup]

I suspect same cause, but different code. Opened a fix for this one at https://dart-review.googlesource.com/c/sdk/+/312441

[incendial]

Ah, these DeclaredIdentifier's ... 🥲
Recently discovered that several rules in DCM were not covering them at all. Honestly, I'm really surprised it's a separate type of node (and not a variable declaration or it's variance).

[DanTup]

I don't know all the details, but there seem to be some differences between the classes (for ex. VariableDeclaration has things like an initializer and is documented as always being a child of VariableDeclarationList, so it doesn't have keyword because that's on the list).

I don't know if something changed here recently though, I feel like I've seen a few issues related to this recently (such as the one you linked above - which had a similar fix) - although for loops are definitely not new!

[DanTup]

This is fixed by dart-lang/sdk@28ea45c. It's in the server so will show up in a future SDK release.