Skip to content

Cannot differentiate two devices of the same type in the device selector #4632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vammex opened this issue Jul 4, 2023 · 18 comments
Closed
Labels
in flutter Relates to running Flutter apps is enhancement
Milestone

Comments

@vammex
Copy link

vammex commented Jul 4, 2023

Type: Bug

i have two same phones. when i connect both to computer, vs code shows their names in "select device to use" and they are same. cannot understand what is what.
it is a name of phone model, so it cannot be fixed manually at the settings. it is a hardware phone name.
vs code does not allow me to choose how, by which name i want to see list of devices

Extension version: 3.66.0
VS Code version: Code 1.79.2 (695af097c7bd098fbf017ce3ac85e09bbc5dda06, 2023-06-14T08:57:04.379Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info
Item Value
CPUs 12th Gen Intel(R) Core(TM) i7-12700H (20 x 2688)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 31.68GB (8.59GB free)
Process Argv --crash-reporter-id ed28006d-76f3-4ab1-ac8a-b9e18a52c2cc
Screen Reader yes
VM 0%
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30776702
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
vsccc:30610678
282f8724:30602487
pyind779:30671433
f6dab269:30613381
pythonsymbol12:30671437
showlangstatbar:30737416
vsctsb:30748421
pythonms35:30701012
03d35959:30757346
pythonfmttext:30731395
pythoncmv:30756943
fixshowwlkth:30771522
pythongtdpath:30769146
i26e3531:30780429
pythonnosm12tcf:30779713
pythonidxptcf:30772540
pythonnoceb:30776495

@DanTup
Copy link
Member

DanTup commented Jul 4, 2023

Could you post the output of running flutter devices --machine in a terminal when both devices are connected? Thanks!

@DanTup DanTup added the awaiting info Requires more information from the customer to progress label Jul 4, 2023
@vammex
Copy link
Author

vammex commented Jul 4, 2023

[
  {
    "name": "VNE AN00",
    "id": "A6QUCP2C05400813",
    "isSupported": true,
    "targetPlatform": "android-arm64",
    "emulator": false,
    "sdk": "Android 11 (API 30)",
    "capabilities": {
      "hotReload": true,
      "hotRestart": true,
      "screenshot": true,
      "fastStart": true,
      "flutterExit": true,
      "hardwareRendering": false,
      "startPaused": true
    }
  },
  {
    "name": "VNE AN00",
    "id": "A6QUCP2C26403181",
    "isSupported": true,
    "targetPlatform": "android-arm64",
    "emulator": false,
    "sdk": "Android 12 (API 31)",
    "capabilities": {
      "hotReload": true,
      "hotRestart": true,
      "screenshot": true,
      "fastStart": true,
      "flutterExit": true,
      "hardwareRendering": false,
      "startPaused": true
    }
  },
  ]

their ID are different and android studio for example does show me a difference between two devices

@DanTup
Copy link
Member

DanTup commented Jul 4, 2023

Is Android Studio just showing the raw ID (A6QUCP2C26403181 and A6QUCP2C05400813)? I think we should be able to include that here fairly easily.

@DanTup DanTup added is enhancement in flutter Relates to running Flutter apps and removed awaiting info Requires more information from the customer to progress labels Jul 4, 2023
@DanTup DanTup added this to the v3.70.0 milestone Jul 4, 2023
@DanTup DanTup changed the title cannot recognize my devide Cannot differentiate two devices of the same type in the device selector Jul 4, 2023
@vammex
Copy link
Author

vammex commented Jul 4, 2023

Is Android Studio just showing the raw ID (A6QUCP2C26403181 and A6QUCP2C05400813)? I think we should be able to include that here fairly easily.
AS shows both hardware name and ID.
yes it may be enough. how to do it?

@DanTup
Copy link
Member

DanTup commented Jul 4, 2023

I've made a change that will add the ID to the device selector like this.

Before

Screenshot 2023-07-04 151459

After

Screenshot 2023-07-04 151436

Will this solve the issue for you?

@DanTup DanTup closed this as completed in 54db688 Jul 4, 2023
@vammex
Copy link
Author

vammex commented Jul 4, 2023

I've made a change that will add the ID to the device selector like this.

Before

Screenshot 2023-07-04 151459

After

Screenshot 2023-07-04 151436

Will this solve the issue for you?

if it will look like VNE AN00 - A6QUCP2C05400813
it's good

@DanTup
Copy link
Member

DanTup commented Jul 4, 2023

Yep! The brightest text will be "VNE AN00" (eg. where mine says "Mi A2"), and the ID "A6QUCP2C05400813" will be the first part of the next text (where mine says "33aa844").

@vammex
Copy link
Author

vammex commented Jul 5, 2023

Yep! The brightest text will be "VNE AN00" (eg. where mine says "Mi A2"), and the ID "A6QUCP2C05400813" will be the first part of the next text (where mine says "33aa844").

I do not understand, you do not plan to tell me HOW to make it?

@DanTup
Copy link
Member

DanTup commented Jul 5, 2023

The change is in the Dart extension code. I have made that change, but you will need a new version of the Dart extension to see it.

I will publish a pre-release version later this week, and you can switch to that if you would like to get the update before the next stable release.

@vammex
Copy link
Author

vammex commented Jul 5, 2023

The change is in the Dart extension code. I have made that change, but you will need a new version of the Dart extension to see it.

I will publish a pre-release version later this week, and you can switch to that if you would like to get the update before the next stable release.

oh you are the developer? I have not got it.
so please show me a screenshot with your real phone names details?

@DanTup
Copy link
Member

DanTup commented Jul 5, 2023

Yes, I'm a developer on the Dart extension.

The image from above included my test phone - the name is "Mi A2" and the ID is "33aa844". Before the change, the ID was not shown, but now it is:

image

I will push a pre-release version tomorrow and provide instructions so you can update and test it out.

@vammex
Copy link
Author

vammex commented Jul 6, 2023

Yes, I'm a developer on the Dart extension.

The image from above included my test phone - the name is "Mi A2" and the ID is "33aa844". Before the change, the ID was not shown, but now it is:

image

I will push a pre-release version tomorrow and provide instructions so you can update and test it out.

👍

@vammex
Copy link
Author

vammex commented Jul 6, 2023

version 38 is out. is there smth?

@DanTup
Copy link
Member

DanTup commented Jul 6, 2023

version 38 is out. is there smth?

I'm not sure what version 38 you're referring to. The current extension version is 3.68.

Anyway, I have published pre-release versions of the extensions. Please click the "Switch to Pre-Release" buttons for Dart + Flutter extensions and then click the "Reload" buttons once they have finished installing:

Dart/Flutter pre-release versions

These include the updates, and you should be able to see the IDs in the device picker. Please let me know if this doesn't work for you.

Thanks!

@vammex
Copy link
Author

vammex commented Jul 6, 2023

photo_2023-07-06_17-56-54
genius

right for now, it is good enough.
in future, will it be possible to set some name to devices? cannot figure out now which logic do i mean, whether vs code will remember commonly connected devices, or else to set a name every time after connecting

@DanTup
Copy link
Member

DanTup commented Jul 6, 2023

in future, will it be possible to set some name to devices?

Please file a new issue requesting this. If people add 👍 s and it seems useful to many, we could consider it. Thanks!

@vammex
Copy link
Author

vammex commented Jul 9, 2023

in future, will it be possible to set some name to devices?

Please file a new issue requesting this. If people add 👍 s and it seems useful to many, we could consider it. Thanks!

ok. oh i have been suffered this issue since February and I did not know I can just solve it that easy by writing an issue report )

@DanTup
Copy link
Member

DanTup commented Jul 10, 2023

I did not know I can just solve it that easy by writing an issue report )

It's not guaranteed everything raised gets fixed quickly, but things are definitely more likely to be addressed if they have been raised, because otherwise I might not know about the issues :-)

If you find bugs or have suggestions, please do open issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in flutter Relates to running Flutter apps is enhancement
Projects
None yet
Development

No branches or pull requests

2 participants