Support global evaluation in SDK DAPs #4636

Activity

1. DanTup

   added

   is bug

   in debuggingRelates to the debug adapter or process of running debug sessionsRelates to the debug adapter or process of running debug sessions

   on Jul 10, 2023
2. DanTup

   added this to the v3.70.0 milestone on Jul 10, 2023
3. DanTup

   closed this as completedin 7389b2con Jul 11, 2023
4. copybara-service

   added a commit that references this issue on Jul 11, 2023

   [dds/dap] Add some basic global evaluation support

   ...

   80a6670
5. jacob314 commented on Aug 1, 2023

   

   jacob314

   on Aug 1, 2023

   More actions

   What will it take to support evaluating in the context of the library of the currently open file and/or adding some affordance in the UI to select the library to use?
6. DanTup commented on Aug 1, 2023

   

   DanTup

   on Aug 1, 2023

   MemberAuthor

   More actions

   What will it take to support evaluating in the context of the library of the currently open file

   That's actually what we do :) The comment above didn't mention it, but we pass through the active file in the context (it's non-standard, but all we have for now):

   Dart-Code/src/extension/providers/debug_adapter_global_evaluation_context_factory.ts

   Lines 34 to 39 in 7389b2c

   	if (message.command === "evaluate" && message.arguments?.context === "repl") {
   	const doc = getActiveRealFileEditor()?.document;
   	if (doc && isDartDocument(doc)) {
   	message.arguments.context = doc?.uri.toString();
   	}
   	}

   And then in the debug adapter, we read this and find the relevant library for that script:

   https://github.com/dart-lang/sdk/blob/80a6670d5d081bf6542036979791a8f666adfc1d/pkg/dds/lib/src/dap/adapters/dart.dart#L975

   There's no UI to allow you to select, it just uses the current file. We could change this, although I don't know how nice the UI would be - but you can always open a specific file if you want to use that library.

   What we don't support though is a way to choose the isolate.
7. rizkyhaksono

   added a commit that references this issue on Apr 6, 2024

   Enable global evaluation for new SDK DAPs by providing current file a…

   ...

   7389b2c