"Inline local variable" adds extra parens to switch expression

[lukehutch]

Describe the bug

Before:

Choose "Inline local variable":

After:

There are extra (unnecessary) parens added inside the existing switch expression parens.

To Reproduce

As above

Expected behavior

The result should be

Please complete the following information:

• Operating System and version: Linux
• VS Code version: Latest public release
• Dart extension version: Latest public release
• Dart/Flutter SDK version: Latest public release
• Target device (if the issue relates to Flutter debugging):

[DanTup]

@lukehutch do you have a complete code sample that repros this? I tried with this, but it seemed to work correctly:

void f(int a) {
  var test = a;
  var b = switch (test) {
    _ => '',
  };
}

I don't see any recent changes that may have fixed this, so I presume there's something different in your case that triggers this.

[lukehutch]

class Test {
  static var bob = 5;
}

void main(List<String> args) {
  final t = Test.bob;
  var s = switch (t) {
    5 => 'bob',
    _ => '',
  };
  print(s);
}

Try inlining t to see the problem.

[DanTup]

I don't seem to be able to repro using the code above. I tried both with both 3.1.0 and 3.2.0. Is there anything else in your project that might be affecting the results, or can you confirm an exact SDK version and that you can repro this in a newly created project so we're testing with the same thing?

Thanks!

inline.mp4

[lukehutch]

I can still replicate this in a brand new project.

$ rpm -q code
code-1.82.2-1694671900.el7.x86_64

$ dart --version
Dart SDK version: 3.1.0 (stable) (Tue Aug 15 21:33:36 2023 +0000) on "linux_x64"

Here's my user settings:

{
    "[dart]": {
        "editor.formatOnSave": true,
        "editor.formatOnType": true,
        "editor.rulers": [
            80
        ],
        "editor.selectionHighlight": false,
        "editor.suggest.snippetsPreventQuickSuggestions": false,
        "editor.suggestSelection": "first",
        "editor.tabCompletion": "onlySnippets",
        "editor.wordBasedSuggestions": false
    },
    "workbench.tree.indent": 20,
    "dart.debugExternalPackageLibraries": true,
    "dart.debugSdkLibraries": false,
    "explorer.confirmDragAndDrop": false,
    "workbench.colorTheme": "Default Dark+ Experimental",
    "timeline.pageSize": 999,
    "dart.warnWhenEditingFilesOutsideWorkspace": false,
    "cmake.configureOnOpen": true,
    "redhat.telemetry.enabled": false,
    "git.openRepositoryInParentFolders": "always",

    "java.configuration.updateBuildConfiguration": "automatic",
    "editor.codeActionsOnSave": {
        "source.fixAll": true,
        "source.organizeImports": true
    },
    "editor.formatOnSave": true,
    "workbench.colorCustomizations": {
        "tab.activeBorder": "#ffff00",
        "tab.unfocusedActiveBorder": "#000000"
    },
    "android.sdkLocation": "/home/luke/Android/Sdk/platforms/android-33"
}

[DanTup]

Sorry, I can repro this - I was inlining the wrong variable (s) 🤦‍♂️

[DanTup]

Fixed by dart-lang/sdk@cc7dd80 - ships in a future SDK release.