Skip to content

Extract Local Variable no longer uses server-generated name #4786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanTup opened this issue Oct 11, 2023 · 1 comment
Closed

Extract Local Variable no longer uses server-generated name #4786

DanTup opened this issue Oct 11, 2023 · 1 comment
Labels
in editor Relates to code editing or language features is bug
Milestone
v3.76.0

Comments

@DanTup
Copy link
Member

DanTup commented Oct 11, 2023

Implementing #4749 has resulted in not using the server-generated name for a local variable. This feels worse than the behaviour before, so we should revert it and re-opened it to come up with a better solution.
@DanTup DanTup added is bug in editor Relates to code editing or language features labels Oct 11, 2023
@DanTup DanTup added this to the v3.76.0 milestone Oct 11, 2023
@DanTup DanTup mentioned this issue Oct 11, 2023
Closed
DanTup added a commit that referenced this issue Oct 11, 2023
@DanTup
Revert changes to prompt for variables names during Extract Local Var…
944a663 
…iable

Reverts 56b30ec and 2c571b2.

This change requires typing a name in all cases, whereas before the server
generated name would often be acceptable.

See #4786.
@DanTup
Copy link
Member Author

DanTup commented Oct 11, 2023

944a663 reverted the fix for #4749, resolving this issue.

@DanTup DanTup closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in editor Relates to code editing or language features is bug
Projects
None yet
Milestone
v3.76.0
Development

No branches or pull requests
1 participant
@DanTup