Skip to content

Type label in autocomplete is not displayed for record fields #4788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
incendial opened this issue Oct 11, 2023 · 2 comments
Closed

Type label in autocomplete is not displayed for record fields #4788

incendial opened this issue Oct 11, 2023 · 2 comments
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.76.0

Comments

@incendial
Copy link

Describe the bug
When typing a record field in the editor, the autocomplete menu does not show the type of suggest fields:
image

Please complete the following information:

Dart Code extension: 3.74.0

App: Visual Studio Code
App Host: desktop
Version: mac 1.83.0

Workspace type: Dart (LSP)

Dart (3.2.0-134.1.beta): /Users/dimannich/Desktop/flutter/bin/cache/dart-sdk
Flutter (3.15.0-15.2.pre): /Users/dimannich/Desktop/flutter
@DanTup DanTup added this to the v3.76.0 milestone Oct 11, 2023
@DanTup DanTup added in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available labels Oct 11, 2023
@DanTup
Copy link
Member

DanTup commented Oct 11, 2023 •
edited
Loading

Good spot - fix open at https://dart-review.googlesource.com/c/sdk/+/330107. Will ship in the SDK. Thanks!

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 23, 2023
@DanTup
[analsysis_server] Fix missing types on record fields in LSP completi…
9e75379 
…on detail

Fixes Dart-Code/Dart-Code#4788

Change-Id: Iaa57a5e486dac6c1978b8576b4855f8c3e8955f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330107
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
@DanTup
Copy link
Member

DanTup commented Oct 23, 2023

Fixed by dart-lang/sdk@9e75379. The fix is in the Dart analysis server so will ship in a future Dart/Flutter SDK (not a Dart-Code update).

@DanTup DanTup closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Milestone
v3.76.0
Development

No branches or pull requests
2 participants
@DanTup @incendial