Closure completions are not showing up in VS Code

[DanTup]

While looking into #4834, I don't see any closure completions even using code from the test:

[DanTup]

From the log... labels are missing:

{
	"insertTextFormat": 2,
	"kind": 2,
	"label": "",
	"sortText": "9099",
	"textEditText": "(a, b) {\n      $0\n    },"
},
{
	"insertTextFormat": 2,
	"kind": 2,
	"label": "",
	"sortText": "9099",
	"textEditText": "(a, b) => $0,"
},

Something is likely going wrong with the mapping - this also suggests we have no LSP tests for closures.

[DanTup]

https://dart-review.googlesource.com/c/sdk/+/335822

[DanTup]

Fixed by dart-lang/sdk@28d9ac0

[DanTup]

This came up in #4845 too.

@bwilkerson @jacob314 FYI - when I fixed this last week I thought the bug had only made bleeding-edge SDKs, but apparently I got the branch date wrong and the bug shipped in stable.

I don't know if it meets the bar for a cherry-pick, but it might may come up a lot given how common function parameters are in Flutter. The actual fix is pretty trivial (see dart-lang/sdk@28d9ac0).

[DanTup]

Since this issue is being raised a lot, here's a summary that I can link to from other issues I'm closing as a dupe.

Edit: 2023-12-01: This bug was in the Dart 3.2 / Flutter 3.16 SDK releases and a fix has been hot-fixed into Dart 3.2.2 / Flutter 3.16.2.

If you're still seeing this, please update to the latest Dart/Flutter and restart VS Code.