Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement refactor: Convert getter to method/method to getter in LSP #542

Closed
DanTup opened this issue Feb 8, 2018 · 4 comments
Closed

Implement refactor: Convert getter to method/method to getter in LSP #542

DanTup opened this issue Feb 8, 2018 · 4 comments
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is enhancement
Milestone
v3.25.0

Comments

@DanTup
Copy link
Member

DanTup commented Feb 8, 2018

No description provided.

@DanTup DanTup added is enhancement in editor Relates to code editing or language features labels Feb 8, 2018
@DanTup DanTup added this to the On Deck milestone Feb 8, 2018
@DanTup DanTup mentioned this issue Feb 8, 2018
Closed
@DanTup DanTup added the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Feb 12, 2018
@DanTup
Copy link
Member Author

DanTup commented Feb 12, 2018

I don't think putting refactors on the lightbulb is a good idea, as they show up so frequently that there will just be bulbs everywhere always. I suggest these go on the context menu:

microsoft/vscode#9827

@DanTup DanTup removed the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Feb 21, 2018
@DanTup
Copy link
Member Author

DanTup commented Dec 19, 2018

Requires dart-lang/sdk#35448.

@DanTup DanTup added the blocked on dart / flutter Requires a change in Dart or Flutter to progress label Dec 19, 2018
@DanTup DanTup modified the milestones: On Deck, Backlog Mar 19, 2019
@DanTup DanTup added the in lsp/analysis server Something to be fixed in the Dart analysis server label Jun 1, 2020
@DanTup DanTup modified the milestones: Backlog, On Deck Nov 18, 2020
@DanTup DanTup removed the blocked on dart / flutter Requires a change in Dart or Flutter to progress label Nov 18, 2020
@DanTup DanTup modified the milestones: On Deck, v3.25.0 Jun 28, 2021
@DanTup DanTup changed the title Implement refactor: Convert getter to method Implement refactor: Convert getter to method/method to getter in LSP Jul 20, 2021
dart-bot pushed a commit to dart-lang/sdk that referenced this issue Jul 20, 2021
@DanTup
[analysis_server] Support convert method<->getters refactor in LSP
094e4fe 
Fixes Dart-Code/Dart-Code#542.

Change-Id: Iff68f0df9956c7dcea560400e558a6e26b6c2ce1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
@DanTup
Copy link
Member Author

DanTup commented Jul 20, 2021

Fixed by dart-lang/sdk@094e4fe.

@DanTup DanTup closed this as completed Jul 20, 2021
@0833347379

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is enhancement
Projects
None yet
Milestone
v3.25.0
Development

No branches or pull requests
2 participants
@DanTup @0833347379