Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement refactor: Inline method #547

Closed
DanTup opened this issue Feb 8, 2018 · 6 comments
Closed

Implement refactor: Inline method #547

DanTup opened this issue Feb 8, 2018 · 6 comments
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Feb 8, 2018

No description provided.

@DanTup DanTup added is enhancement in editor Relates to code editing or language features labels Feb 8, 2018
@DanTup DanTup added this to the On Deck milestone Feb 8, 2018
@DanTup DanTup added the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Feb 12, 2018
@DanTup
Copy link
Member Author

DanTup commented Feb 12, 2018

I don't think putting refactors on the lightbulb is a good idea, as they show up so frequently that there will just be bulbs everywhere always. I suggest these go on the context menu:

microsoft/vscode#9827

@DanTup DanTup removed the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Feb 21, 2018
@DanTup
Copy link
Member Author

DanTup commented Dec 19, 2018

Requires dart-lang/sdk#35448.

@DanTup DanTup added the blocked on dart / flutter Requires a change in Dart or Flutter to progress label Dec 19, 2018
@DanTup DanTup modified the milestones: On Deck, Backlog Mar 19, 2019
@DanTup DanTup modified the milestones: Backlog, On Deck Nov 18, 2020
@DanTup DanTup added in lsp/analysis server Something to be fixed in the Dart analysis server and removed blocked on dart / flutter Requires a change in Dart or Flutter to progress labels Nov 18, 2020
@DanTup DanTup modified the milestones: On Deck, v3.22.0 Apr 27, 2021
@svarlet
Copy link

svarlet commented Apr 28, 2021

Hi @DanTup !
I just noticed the completion of the similar issue about inlining variables. What's the status on this issue? Inlining methods is an even more useful refactoring 😍

@DanTup
Copy link
Member Author

DanTup commented Apr 28, 2021

@svarlet hoping to look at this shortly too :-)

@DanTup
Copy link
Member Author

DanTup commented Apr 29, 2021

I've got a change open for this at https://dart-review.googlesource.com/c/sdk/+/197380/.

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Apr 29, 2021
Fixes Dart-Code/Dart-Code#547.

Change-Id: I02f905673820ef22b5b10055f32710d660beaa2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
@DanTup
Copy link
Member Author

DanTup commented Apr 29, 2021

Fixed in dart-lang/sdk@a89fccb.

@DanTup DanTup closed this as completed Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features in lsp/analysis server Something to be fixed in the Dart analysis server is enhancement
Projects
None yet
Development

No branches or pull requests

2 participants