Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakpoints are marked as verified before being resolved #764

Closed
DanTup opened this issue Apr 2, 2018 · 2 comments
Closed

Breakpoints are marked as verified before being resolved #764

DanTup opened this issue Apr 2, 2018 · 2 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.64.0

Comments

@DanTup
Copy link
Member

DanTup commented Apr 2, 2018

Seems like we always say breakpoints are verified when we get back an unresolved confirmation. I think they should remain unverified until we get BreakpointResolved (which we currently ignore).
@DanTup DanTup added is bug in debugger Relates to the debug adapter or process of launching a debug session labels Apr 2, 2018
@DanTup DanTup added this to the v2.12.0 milestone Apr 2, 2018
@DanTup DanTup modified the milestones: v2.12.0, v2.13.0 Apr 16, 2018
@DanTup DanTup mentioned this issue May 3, 2018
Closed
@DanTup DanTup modified the milestones: v2.13.0, v2.14.0 May 14, 2018
@DanTup DanTup modified the milestones: v2.14.0, v2.15.0 Jun 7, 2018
@DanTup DanTup modified the milestones: v2.15.0, On Deck Jun 21, 2018
@DanTup DanTup modified the milestones: On Deck, v2.20.0 Oct 4, 2018
@DanTup DanTup added the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Oct 18, 2018
@DanTup
Copy link
Member Author

DanTup commented Oct 23, 2018

Progress is on the breakpoint-resolution branch, but stalled by microsoft/vscode#59984.

@DanTup DanTup modified the milestones: v2.20.0, On Deck Oct 23, 2018
@DanTup DanTup modified the milestones: On Deck, v.1.22.0 Nov 12, 2018
@DanTup DanTup removed the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Nov 12, 2018
@DanTup DanTup mentioned this issue Nov 15, 2018
Closed
@DanTup DanTup modified the milestones: v2.22.0, On Deck Dec 17, 2018
DanTup added a commit that referenced this issue Jan 3, 2019
@DanTup
Change how we handle breakpoints to support resolution
f237078 
Fixes #764.
DanTup added a commit that referenced this issue Jan 3, 2019
@DanTup
Change how we handle breakpoints to support resolution
a6ad395 
Fixes #764.
DanTup added a commit that referenced this issue Jan 3, 2019
@DanTup
Change how we handle breakpoints to support resolution
7776038 
Fixes #764.
@DanTup DanTup modified the milestones: On Deck, Backlog Mar 19, 2019
@DanTup DanTup removed this from the Backlog milestone Feb 22, 2023
@DanTup DanTup modified the milestones: On Deck, v3.62.0 Feb 22, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Feb 28, 2023
@DanTup
[dds/dap] Add support for breakpoint resolution
55cb3ce 
Previously we just always sent verified:true for all breakpoints and never handled resolution. This meant breakpoints always appeared verified in VS Code, and did not update to their correct locations when resolved.

This change sends verified:false initially, and then uses the BreakpointAdded/BreakpointResolved events to send verified:true and an updated location as the events arrive.

Fixes Dart-Code/Dart-Code#764.

Change-Id: I5b008bef802bb1c31219175a03498f5015ec4a04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285909
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
@DanTup
Copy link
Member Author

DanTup commented Feb 28, 2023

Fixed by dart-lang/sdk@55cb3ce.

@DanTup DanTup closed this as completed Feb 28, 2023
@DanTup DanTup added the relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available label Feb 28, 2023
@DanTup DanTup modified the milestones: v3.62.0, Requires SDK Release Feb 28, 2023
@DanTup DanTup modified the milestones: Requires SDK Release, v3.64.0 May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in debugger Relates to the debug adapter or process of launching a debug session is bug relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available
Projects
None yet
Milestone
v3.64.0
Development

No branches or pull requests
1 participant
@DanTup