Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid activation failures due to link file errors #1466

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

tsangint
Copy link
Contributor

@tsangint tsangint commented Feb 16, 2019

test

Reproduce step:

// In the project folder's primary directory
touch ln_origin.txt 
ln -s ln_origin.txt ln_linked.txt
rm ln_origin.txt
// open VSCode and activate Dart-Code(Flutter plugin)

If there is a soft link file, but the original file is deleted, fs.statSyncwill throw an error and cause the activation to fail.

@DanTup DanTup changed the base branch from master to dev February 18, 2019 10:05
@DanTup DanTup added this to the v2.25.0 milestone Feb 18, 2019
@DanTup
Copy link
Member

DanTup commented Feb 18, 2019

Good spot! Thanks for the fix! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants