Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for target-platform to Flutter launch config. #1720

Merged
merged 2 commits into from
May 20, 2019

Conversation

ened
Copy link
Contributor

@ened ened commented May 17, 2019

flutter --target-platform allows developers to choose the target architecture.

It's auto-selected but sometimes there is a definitive need to specify the field sometimes, e.g. App testing for different phones / architectures.

@DanTup
Copy link
Member

DanTup commented May 17, 2019

Thanks for the PR! Though is this not something you can just add directly to args in your launch configs?

@ened
Copy link
Contributor Author

ened commented May 17, 2019

Yes, it can be added to the args. A dropdown field is a lot easer (especially when it offers auto-completion).

@DanTup
Copy link
Member

DanTup commented May 17, 2019

That's true. I'm a little worried about starting down a path where we end up adding all of Flutter's command line switches in here and having to keep them up to date (and potentially deal with multiple versions). We already have some like debug/profile mode, but for those there's an intention to expose them as first class commands ("run in profile mode") to avoid having to maintain multiple configs of keep editing the file which I think makes them more valuable.

I'll think more about this when back in the office.

@DanTup DanTup merged commit ba6d619 into Dart-Code:master May 20, 2019
@DanTup
Copy link
Member

DanTup commented May 20, 2019

I've merged this one, though I think we might want to tweak it a little when other platforms like Web are fully supported in the main flutter tool depending on how they're supported.

Thanks!

@DanTup DanTup added this to the v3.1.0 milestone May 20, 2019
@DanTup DanTup added in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is enhancement labels May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants