Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only select ephemeral devices #1807

Merged
merged 4 commits into from Jun 20, 2019
Merged

Only select ephemeral devices #1807

merged 4 commits into from Jun 20, 2019

Conversation

DanTup
Copy link
Member

@DanTup DanTup commented Jun 20, 2019

For older versions we just treat every device as auto-selectable, but when Flutter tells us a device is not ephemeral (Desktop/Web) we don't auto-select it unless there are no other devices.

This can be improved further (only auto-select if it's valid for an open project), but this will at least avoid the issue where a desktop device is selected upon opening a project if the mobile is already connected (the devices come through with mobile first, desktop second).

@DanTup DanTup added is enhancement in flutter Relates to running Flutter apps labels Jun 20, 2019
@DanTup DanTup added this to the v3.2.0 milestone Jun 20, 2019
@DanTup DanTup merged commit b82e4f2 into master Jun 20, 2019
@DanTup DanTup deleted the improve-device-handling branch June 20, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in flutter Relates to running Flutter apps is enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant