Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show log events from dart:developer log() in the debug console (if enabled) #1849

Merged
merged 2 commits into from Jul 16, 2019

Conversation

DanTup
Copy link
Member

@DanTup DanTup commented Jul 10, 2019

Required to do #1824. Not so, Flutter's errors come through as Flutter.Error and are separate to dart:developer's log(). This just exposes logs that would otherwise not be visible to the user.

@DanTup DanTup added is enhancement in debugger Relates to the debug adapter or process of launching a debug session labels Jul 10, 2019
@DanTup DanTup added this to the v3.3.0 milestone Jul 10, 2019
@DanTup
Copy link
Member Author

DanTup commented Jul 10, 2019

@devoncarew I added code to print Logging events, though I'm not sure how spammy this is going to be (we have no good way to filter it in VS Code here, so if lots of libraries write a lot of output, it's going to fill the users debug console).

I could write the output all to another pane (an Output channel), though we don't have any ability to link to source code in there (though I don't know that matters for these?).

@devoncarew
Copy link
Contributor

I think having it in-line with the other output makes sense. If things do get too verbose, we may want to add ways to toggle on and off specific channels, or hide the output altogether.

@DanTup
Copy link
Member Author

DanTup commented Jul 10, 2019

I was thinking that if a user pulls in some dependency that is really chatty and we don't already have some filter, their own output could get lost. There's no great way for us to build a UI to let them filter out sources (the best we can do right now is probably in the Workspace Settings JSON, excluding them by name). I have no idea how many people use dart:developer's log function though. If it's practically nobody, then it's less urgent (if it's used a lot, I think we probably need some sort of filter before we ship this).

@DanTup DanTup changed the title Show log events from dart:developer log() in the debug console Show log events from dart:developer log() in the debug console (if setting enabled) Jul 16, 2019
@DanTup DanTup changed the title Show log events from dart:developer log() in the debug console (if setting enabled) Show log events from dart:developer log() in the debug console (if enabled) Jul 16, 2019
@DanTup DanTup merged commit c2c2ae9 into master Jul 16, 2019
@DanTup DanTup deleted the show-dart-dev-logs branch July 16, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session is enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants